-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: overwrite AdaptVQE.supports_aux_operators
#9142
fix: overwrite AdaptVQE.supports_aux_operators
#9142
Conversation
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
AdaptVQE.supports_aux_operators
Pull Request Test Coverage Report for Build 3480787356
💛 - Coveralls |
c3c5752
to
555ed3c
Compare
LGTM, could you add a small test to ensure this is covered? 🙂 |
555ed3c
to
0c74229
Compare
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit e4ea067)
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Summary
AdaptVQE
does indeed support aux operators but did not overwrite the default classmethod of theMinimumEigensolver
interface. This PR fixes that.Details and comments