Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: overwrite AdaptVQE.supports_aux_operators #9142

Merged
merged 2 commits into from
Nov 18, 2022

Conversation

mrossinek
Copy link
Member

Summary

AdaptVQE does indeed support aux operators but did not overwrite the default classmethod of the MinimumEigensolver interface. This PR fixes that.

Details and comments

@mrossinek mrossinek added stable backport potential The bug might be minimal and/or import enough to be port to stable mod: algorithms Related to the Algorithms module labels Nov 16, 2022
@mrossinek mrossinek added this to the 0.22.3 milestone Nov 16, 2022
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

@mrossinek mrossinek changed the title fix: overwrite AdaptVQE.supports_aux_operators fix: overwrite AdaptVQE.supports_aux_operators Nov 16, 2022
@coveralls
Copy link

coveralls commented Nov 16, 2022

Pull Request Test Coverage Report for Build 3480787356

  • 4 of 5 (80.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.04%) to 84.608%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/algorithms/minimum_eigensolvers/adapt_vqe.py 4 5 80.0%
Files with Coverage Reduction New Missed Lines %
src/sabre_swap/layer.rs 2 98.95%
Totals Coverage Status
Change from base Build 3473657686: 0.04%
Covered Lines: 62620
Relevant Lines: 74012

💛 - Coveralls

@mrossinek mrossinek force-pushed the adapt-vqe-supports-aux-operators branch from c3c5752 to 555ed3c Compare November 16, 2022 15:08
@Cryoris
Copy link
Contributor

Cryoris commented Nov 16, 2022

LGTM, could you add a small test to ensure this is covered? 🙂

@mrossinek mrossinek force-pushed the adapt-vqe-supports-aux-operators branch from 555ed3c to 0c74229 Compare November 16, 2022 15:36
@woodsp-ibm woodsp-ibm added the Changelog: Bugfix Include in the "Fixed" section of the changelog label Nov 16, 2022
@mergify mergify bot merged commit e4ea067 into Qiskit:main Nov 18, 2022
mergify bot pushed a commit that referenced this pull request Nov 18, 2022
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit e4ea067)
@mrossinek mrossinek deleted the adapt-vqe-supports-aux-operators branch November 18, 2022 16:53
mergify bot added a commit that referenced this pull request Nov 22, 2022
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit e4ea067)

Co-authored-by: Max Rossmannek <oss@zurich.ibm.com>
Cryoris pushed a commit to Cryoris/qiskit-terra that referenced this pull request Jan 12, 2023
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
ElePT pushed a commit to ElePT/qiskit that referenced this pull request Jun 27, 2023
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
ElePT pushed a commit to ElePT/qiskit-algorithms-test that referenced this pull request Jul 17, 2023
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog mod: algorithms Related to the Algorithms module stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants